Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bundle] Add more details on the DDF bundle descriptor #46

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Zehir
Copy link
Contributor

@Zehir Zehir commented Jan 2, 2024

This PR is a draft to discuss about changes to do for the DDF bundles.

I don't know how you planned to store in the database from the bundle, about the DESC chunk, either we filter out some attributes to keep only a few (version_deconz, last_modified, product and device_identifiers) for the global query. Or we just return the complete DESC using just a regex to merge the JSON into the response.

The endpoint GET /api/<apikey>/ddf/descriptors should at least return more info about the bundle and the list of devices that is currently using the bundle.

Or this is planned to be added on the /devices/<mac> endpoint ?

@Zehir Zehir changed the title Add more details on the DDF bundle descriptor [Bundle] Add more details on the DDF bundle descriptor Jan 2, 2024
@manup
Copy link
Member

manup commented Mar 21, 2024

I like that the more detailed response is only in the single descriptor query.

The endpoint GET /api//ddf/descriptors should at least return more info about the bundle and the list of devices that is currently using the bundle.

Or this is planned to be added on the /devices/ endpoint ?

I'm not in favor to include the "used_by" array here, while it seems useful it's quite a beast to implement and can result in huge responses, for example we have networks in the wild with +150 devices all using the same DDF.

The /devices/<mac> endpoint will contain the the actual used bundle hash, hopefully that should be sufficient to build the UI.

@Zehir
Copy link
Contributor Author

Zehir commented Mar 21, 2024

Ok np

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants