Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDF for OWON AC201 thermostat #7133

Merged
merged 19 commits into from Jul 31, 2023
Merged

Conversation

aryelevin
Copy link
Contributor

@aryelevin aryelevin commented Jul 28, 2023

This is an integration of OWON AC201 AC IR Blaster over ddf including the removal of legacy c code.
I've added the ability to set the IR commands set from the API using the config/pulseconfiguration setting.
I have 3 units of this product, I tested it for full functionality.

@manup manup added this to the v2.23.0-beta milestone Jul 31, 2023
@manup manup changed the title OWON AC201 ddf integration DDF for OWON AC201 thermostat Jul 31, 2023
@manup manup merged commit 213a006 into dresden-elektronik:master Jul 31, 2023
1 check failed
@aryelevin aryelevin deleted the OWON_AC201_DDF branch July 31, 2023 21:37
@Zehir
Copy link
Contributor

Zehir commented Aug 3, 2023

Hello @aryelevin I made the DDF validator and I have some errors reported by this PR, could you take a look at it ?

https://github.com/dresden-elektronik/deconz-rest-plugin/actions/runs/5688976117/job/15419686665#step:3:19

They are all about the item config/pulseconfiguration.

devices/owon/ac201.json:Validation error: 

The value is "00" but hexadecimal values are expected, it's should be "0x00"

Invalid hexadecimal value at "subdevices[0].items[15].read.cmd";
Invalid hexadecimal value at "subdevices[0].items[15].parse.cmd";

I have no idea what is the fcproperty, it's value is 5 what this does ? Also the eval property is an empty string is that valid ?

Unrecognized key(s) in object: 'fc' at "subdevices[0].items[15].read";

The item is missing the data type should be an hexadecimal value with 2 numbers for example "0x00"

Required at "subdevices[0].items[15].write.dt"

@aryelevin
Copy link
Contributor Author

Hi @Zehir ,

Thanks for your comment first.
OK, so, for items[15], please remember, its a cluster command item (zcl:cmd), not an attribute (zcl:attr/zcl[deprecated]), thus:

  1. "fc" property is frame control of the zcl cmd, you can look at "device_access_fn.cpp" file to see more.
  2. The eval of the read is empty since its a raw data input that set to the config.
  3. The hex vs dec data strings: I will verify the functionality of the configuration after fixing, and will update.
  4. The missing data type is just irrelevant to this type of item (zcl:cmd).

Sorry for my late reply, you know, post July-August... lol

@aryelevin
Copy link
Contributor Author

I checked, works perfect with hex commands.
@ebaauw already committed and merged this fix, so no need for anything right now.

@Zehir
Copy link
Contributor

Zehir commented Sep 17, 2023

I checked, works perfect with hex commands.
@ebaauw already committed and merged this fix, so no need for anything right now.

Yes Ebaauw fixed a lot à DDF recently but thanks for your reply ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants