Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in sqlite3 driver. #461

Closed
starwing opened this issue Mar 1, 2014 · 1 comment
Closed

bug in sqlite3 driver. #461

starwing opened this issue Mar 1, 2014 · 1 comment
Milestone

Comments

@starwing
Copy link

starwing commented Mar 1, 2014

at line 23 of sqlite.js:

        // on Windows, paths have a drive letter which is parsed by
        // url.parse() as the hostname. If host is defined, assume
        // it's the drive letter and add ":"
        if (process.platform == "win32" && config.host.match(/^[a-z]$/i)) {

if we use a opts table instead of URL, the config.host may undefined, so have a check is required.

a change to

        if (process.platform == "win32" && config.host && config.host.match(/^[a-z]$/i)) {

avoid this issue.

@dxg dxg added this to the v2.1.4 milestone Mar 5, 2014
@dxg dxg closed this as completed in ed6140f Mar 5, 2014
@dxg
Copy link
Collaborator

dxg commented Mar 5, 2014

Fixed. Will be released with 2.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants