Bug/fix some a11y issues #121
Conversation
|
Deploy request for affectionate-goldberg-7cf473 rejected. Rejected with commit c853ec5 https://docs.netlify.com/configure-builds/environment-variables/#sensitive-variable-policy |
| @@ -55,8 +55,9 @@ const PostAJobForm = ({ | |||
| companyDescription: Yup.string().required( | |||
| 'Please give a brief description of the company and culture.' | |||
| ), | |||
| companyLogo: Yup.mixed().required('Please provide a .png format image of your company logo') | |||
| .test(file => file && file.type === 'image/png'), | |||
| companyLogo: Yup.mixed() | |||
There was a problem hiding this comment.
Prettier in action.
nickytonline
force-pushed
the
bug/fix-some-a11y-issues
branch
from
0a656c8
to
e47a47d
Compare
|
@nickytonline Is there anything a11y compliant we can do about keeping the bg-image for headings on the form sections? |
I'll take a peek later tonight. Didn't realize I removed the bg images, or maybe I'm misunderstanding your comment. 🙃 |
|
The bg pattern is missing in your after screenshot. It may not have rendered if you'd already killed the server before snapping it? |
|
I've updated the PR description @drewclem. It must have been some weird loading issue when I took the screenshot as it seems to be fine on my branch for the background image. Feel free to take the PR for a spin though. |
|
@nickytonline Looks good to me! I figured it was a strange loading instance. I've seen something similar before. |
Resolves all of #118.
These are all fixes caught by the Axe browser extension (Chrome | Firefox) used in conjunction with the Web AIM contrast checker.
Before
After
Before
After
Feel free to suggest better colours. These are the ones I came up with as soon as the Web AIM contrast checker gave me all passes.