Fixed issue where additional contributor info was missing in profile. #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy request for affectionate-goldberg-7cf473 accepted. Accepted with commit 9a59b5e https://app.netlify.com/sites/affectionate-goldberg-7cf473/deploys/5f3fcd617cc2b800070dc41a |
nickytonline
commented
Aug 21, 2020
| @@ -63,14 +63,23 @@ async function generateContributorsJson() { | |||
| '✅ Received the list of contributors for the repository https://github.com/drewclem/protege.' | |||
| ) | |||
|
|
|||
| const individualContributorResponses = await Promise.all( | |||
| rawContributors.map(({ url }) => fetch(url)) | |||
There was a problem hiding this comment.
Before all I was doing was returning the same array, so when they got merged, there was no additional info added to profile info.
Now, I actually use fetch to retrieve the additional info. Not enough coffee I guess. 🙃
| const individualContributorInfos = await Promise.all( | ||
| rawContributors.map((url) => url) | ||
| individualContributorResponses.map((response) => response.json()) |
There was a problem hiding this comment.
Getting the additional profile information properly now.
|
Amazing. I hadn't even noticed they were missing 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my previous work in #115, I created a regression. There was missing contributor profile information with my change. This fixes that. TLDR, the additional profile info was not being pulled properly.
Before
After