Improve the dbseed.js script #263
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/drewclem/protege/or3KD8o1d5eosyyt71SBGk4KhiAD |
nickytonline
requested review from
sethburtonhall and
drewclem
and removed request for
sethburtonhall
|
|
||
| // Seeding data is only for non-production environments. | ||
| if (process.env.NODE_ENV === 'production') { | ||
| throw new Error( |
There was a problem hiding this comment.
Throw an error if we are in the production environment.
| try { | ||
| ;[...Array(10).keys()].map(() => |
There was a problem hiding this comment.
We don't need to map the array as we're not mapping to anything. A loop is good for the job.
| ;[...Array(10).keys()].map(() => | ||
| db.collection('jobs').add({ | ||
| for (let i = 0; i < seedSize; i++) { | ||
| const job = { |
There was a problem hiding this comment.
I found it difficult to grok the job when it was directly in the add method. Happy to put it back if you prefer that.
|
Looks good @nickytonline. Thanks!! |
|
One notable change is to Failing to do so will result in the following error. |
Description
Incorporates all the improvements suggested for dbseed.js in #262.
Related Tickets & Documents
Closes #262
QA Instructions, Screenshots, Recordings
gh co 263yarnto install the new packages.yarn emulatorsto ensure the emulated Firestore is running.node dbseed.jsfrom the root of the project. The database should seed with 10 jobs.yarn emulatorscommand via CTRL + Cyarn emulatorsto ensure the emulated Firestore is running.node dbseed.js --seedSize=15from the root of the project. The database should seed with 15 jobs.[optional] What gif best describes this PR or how it makes you feel?