Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve audio merging from the backend service #190

Open
drewcook opened this issue Oct 21, 2022 · 3 comments · May be fixed by #216
Open

Improve audio merging from the backend service #190

drewcook opened this issue Oct 21, 2022 · 3 comments · May be fixed by #216
Assignees
Labels
enhancement New feature or request

Comments

@drewcook
Copy link
Owner

drewcook commented Oct 21, 2022

Enhancement

User Story

Currently audio merging is handled in a flattening service over https, this requires the user to upload the individual file blobs both to the flattening service and to IPFS during the metadata creation.

In order to remove the need for multiple uploads, we should handle the audio file muxing in browser.

Where we are currently sending the audio blob to the backend merging service, instead we should use ffmpeg to handle merging of multiple file types. This should also enable us to use all of the filetypes supported by wavesurfer. Once the merging is done, the user will still need to upload the flattened audio file to IPFS.

References

@drewcook drewcook added enhancement New feature or request new issue This issue hasn't been triaged from the core team labels Oct 21, 2022
@noahdahlman
Copy link
Collaborator

ffmpeg.wasm is a pure WebAssembly / JavaScript port of FFmpeg. It enables video & audio record, convert and stream right inside browsers. We should try to use this lib to do in browser audio merging.

@drewcook
Copy link
Owner Author

The merging logic with ffmpeg would probably be best to be pulled out in a separate file as a utility and then imported into the component file for use, for separation of concerns and to be able to reuse it later, or create a suite of ffmpeg utilities.

@noahdahlman
Copy link
Collaborator

This is an example of doing concatenation. See also this , which demonstrates the flags for overlaying audio.

@drewcook drewcook linked a pull request Dec 13, 2022 that will close this issue
12 tasks
@noahdahlman noahdahlman assigned noahdahlman and unassigned drewcook Dec 23, 2022
Repository owner deleted a comment from nonchain Feb 23, 2024
Repository owner deleted a comment from jeremigio2706 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@drewcook @noahdahlman and others