Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update audio merging service #216

Open
wants to merge 35 commits into
base: main
Choose a base branch
from

Conversation

drewcook
Copy link
Owner

@drewcook drewcook commented Dec 10, 2022

General Changes

  • Adds in utilities for working with ffmpeg
    • Adds in utility for merging multiple audio blobs together to a singular one
    • Adds in utility to fetch a file and/or use it for transcoding, mainly just stubs this out but doesn't use it
  • Applies new merge utility to minting/buying projects as nfts and cuts down time spent sending to python service
  • Removes all references to python merge backend service, completely decoupling the UI from it

Developer Notes

Add any notes here that may be helpful for reviewers.


Author Checklist

  • The base branch is set to main
  • The title is using Conventional Commit formatting
  • The Github issue has been linked to the PR in the Development section
  • The General Changes section has been filled out
  • Developer Notes have been added (optional)

Reviewer Checklist

  • End-to-end tests are passing without any errors
  • Code style generally follows existing patterns
  • New third-party packages, if any, do not introduce potential security threats
  • There are no CI changes, or they have been OK’d by the devops team
  • Code changes have been quality checked in the ephemeral URL
  • There is at least one approval from the core team
  • Squash and merge has been checked

@vercel
Copy link

vercel bot commented Dec 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ui ✅ Ready (Inspect) Visit Preview Dec 15, 2022 at 7:57PM (UTC)

@drewcook drewcook changed the base branch from feat/audio-merging to main December 10, 2022 19:58
@drewcook drewcook changed the title chore: add in merge util feat: update audio merging service Dec 10, 2022
@drewcook drewcook temporarily deployed to arbor-pr-216 December 11, 2022 20:42 Inactive
@drewcook drewcook temporarily deployed to arbor-pr-216 December 13, 2022 18:03 Inactive
@drewcook drewcook linked an issue Dec 13, 2022 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Dec 15, 2022

Deployment failed with the following error:

Header at index 0 has invalid `source` pattern "/*".

Learn More: https://vercel.link/invalid-route-source-pattern

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve audio merging from the backend service
1 participant