Add advancements/recipes json files #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out you're supposed to directly extend the Minecraft RecipeProvider rather than extending the ForgeRecipeProvider class. The Forge one overrides the saveRecipeAdvancement method to do nothing, so these json files were never generated and the custom recipes weren't showing up in the in-game recipe book when you got the correct materials. Now we extend the correct class in our generator and the files are properly created. This also adjusts the criterion so that you only need to have a lantern to unlock the recipes and not glass panes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out you're supposed to directly extend the Minecraft
RecipeProvider rather than extending the ForgeRecipeProvider class. The
Forge one overrides the saveRecipeAdvancement method to do nothing, so
these json files were never generated and the custom recipes weren't
showing up in the in-game recipe book when you got the correct
materials.
Now we extend the correct class in our generator and the files are
properly created. This also adjusts the criterion so that you only need
to have a lantern to unlock the recipes and not glass panes.