-
Notifications
You must be signed in to change notification settings - Fork 1
Typescript errors #34
Comments
Thanks for bringing this to my attention. Do you know specifically which components are broken? I've got a little bit of time today and maybe tomorrow to take a look at it. Thanks. |
It were quite a few, i just looked at the warnings/problems vscode gave me because of incorrect types. Also Inertia/Inertia was renamed to Inertia/core so the usePage hook isnt typed correctly anymore. |
Thanks! I fixed the ones I could find. I'm honestly not too sure how to fix the usePage hook type right now, but I'll try to get it typed correctly before the end of the weekend. |
Please consider leaving this repo a star! Thank you! |
@drewmw5 hey is the latests version with these fixes published to composer? latests version on packagist is 1.5, but the latest version on this repo is 1.5.2 |
i think |
Good catch! Packagist retrieves the version from the GitHub releases/tags. I misnamed the tag as "v.1.5.2", but it should be "v1.5.2". This is causing the issue. I'm not home right now, but once I am I'll fix the tag names. |
Awesome! I'll give it a test once I get home, but if you'd like to open a PR so you're listed as a contributor, please do so! I'll try to get around to working on things tonight. |
Just opened a PR for it! |
Description:
The newest version of Breeze made some changes to the props of components resulting in typescript giving errors. Could you maybe update this package to solve those? I would have loved to do it myself but i have insufficient knowledge of typescript sadly.
Steps To Reproduce:
Fresh install of laravel with this package.
The text was updated successfully, but these errors were encountered: