Preamble segment handlers #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change simplifies the code a little and improves performance, primarily by removing list allocations. Previously this method would return a materialised collection. This is not necessary, and an enumeration of directories is sufficient. This is an API change, but is unlikely to break many users as this interface is mostly used internally. It also replaces runtime casts (for .NET 3.5, where interface covariance does not exist) with compile time casts.
The method used to return an enumerable, but the type was always a list. This allows a caller to avoid creating a new list if that is what they need, and advertises that this operation is not evaluated lazily.
Several IJpegSegmentMetadataReader implementations behave in a similar manner. This commit pulls out a common base class for them, to reduce duplication and allow consistency.
|
These are good revisions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several
IJpegSegmentMetadataReaderimplementations behave in a similar manner. This PR pulls out a common base class for them, to reduce duplication and allow consistency.Also some minor API changes around collection types. These are generally considered internal APIs, though of course some advanced users may have taken a dependency upon these. In such cases, recompiling against the new binary should be enough.