Skip leading ID3v2 data in MP3 files to allow processing #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows processing to continue. Ideally we would extract the ID3 data too, but we can add that in future.
These are still useful as documentation.
drewnoakes
approved these changes
Jan 30, 2022
There was a problem hiding this comment.
Hi Jürgen,
Thanks very much for this PR.
We avoid adding data files to this source repo, as it can get out of hand very quickly. Instead we use a large corpus of test data, which works well in practice. Please read https://github.com/drewnoakes/metadata-extractor/wiki/Working-with-test-images for more information.
I modified your PR to remove those files, and tweaked the constants and comments a little. I also ran this across the test data and found it fixed a file there.
Thanks again!
Comment on lines
+36
to
+38
| // MP3-File with "ID3" at start | ||
| if (bytes[0] == 0x49 && bytes[1] == 0x44 && bytes[2] == 0x33) | ||
| return Util.FileType.Mp3; |
There was a problem hiding this comment.
I think other types of file can start with ID3 too, though this is an improvement over what we had before.
drewnoakes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #285
Hi,
I took a look at the issue and found, that the sample file has ID3V2 tags at the start of the file.
I added support for this form of a mp3 file by skipping the ID3V2 tag before reading the meta data.
I also changed the MpegAudioTypeChecker class to recognize the ID3V2 tags as mp3 file.
I've shortend the sample file to create a unit test case.
Kind regards
Jürgen Brändle