Tidy up code and eliminate some allocations #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
iamcarbon
commented
Jan 27, 2024
iamcarbon
commented
- Eliminate a possible virtual call in ByteTrieNode
- Updates ShouldAcceptRiffIdentifier to accept utf-8 bytes (eliminating a string allocation)
- Eliminates an allocation in GifReader
- Updates a few classes to use primary constructors
- Replaces some || statements with pattern matching
- Avoids an extra dictionary lookup
- Organizes using statements
- Fixes a few files with mixed line endings
|
@drewnoakes Ready for review / comments. |
iamcarbon
changed the title
iamcarbon
changed the title
drewnoakes
approved these changes
Jan 27, 2024
MetadataExtractor/Formats/Exif/makernotes/FujifilmMakernoteDescriptor.cs
Show resolved
Hide resolved
| @@ -482,34 +482,21 @@ public OlympusMakernoteDescriptor(OlympusMakernoteDirectory directory) | |||
| if (Directory.GetObject(OlympusMakernoteDirectory.TagWbMode) is not short[] values) | |||
| return null; | |||
|
|
|||
| switch ($"{values[0]} {values[1]}".Trim()) | |||
| return $"{values[0]} {values[1]}".Trim() switch | |||
There was a problem hiding this comment.
This could be a switch on a tuple, to avoid the string allocation and hopefully enable a jump table.
Eg
Suggested change
| return $"{values[0]} {values[1]}".Trim() switch | |
| return (values[0], values[1]) switch |
There was a problem hiding this comment.
Added a dependency to ValueTuple, and updated.
|
@drewnoakes Ready to merge if everything looks good to you. I'll hit the rest in another PR. |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.