Remove custom number formatting in ICC #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Analysing some CPU traces showed ~0.5% of sampled CPU stacks were hitting this number formatting function. The code itself looks pretty wild and I'm very happy to be removing it. Half a percent may not seem high, but this is one of the highest CPU consuming methods of the library in the trace, which is definitely not expected. Looks like it was ported over from Java: https://github.com/drewnoakes/metadata-extractor/blob/b19ac0637ff1481bed8029130a9e8669267b4980/Source/com/drew/metadata/icc/IccDescriptor.java#L227-L246. A similar fix would be good there.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analysing some CPU traces showed ~0.5% of sampled CPU stacks were hitting this number formatting function. The code itself looks pretty wild and I'm very happy to be removing it. Half a percent may not seem high, but this is one of the highest CPU consuming methods of the library in the trace, which is definitely not expected.
Looks like it was ported over from Java: https://github.com/drewnoakes/metadata-extractor/blob/b19ac0637ff1481bed8029130a9e8669267b4980/Source/com/drew/metadata/icc/IccDescriptor.java#L227-L246. A similar fix would be good there.