Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GpsDirectory#getGpsDate() locale independent #160

Closed
LZaruba opened this issue Apr 4, 2016 · 2 comments
Closed

Make GpsDirectory#getGpsDate() locale independent #160

LZaruba opened this issue Apr 4, 2016 · 2 comments

Comments

@LZaruba
Copy link
Contributor

LZaruba commented Apr 4, 2016

When running in locale which uses comma as decimal separator, loading of the gps date fails and return snulls which causes ExifDirectoryTest to fail.
LZaruba added a commit to LZaruba/metadata-extractor that referenced this issue Apr 4, 2016
@LZaruba
Make GpsDirectory#getGpsDate() locale independent
29e95df 
- Fixed formatting of the dateTime to be locale independent

GitHub Issue drewnoakes#160
@LZaruba LZaruba mentioned this issue Apr 4, 2016
Merged
@LZaruba
Copy link
Contributor Author

LZaruba commented Apr 4, 2016

I should probably mention that this commit doesn't change any output values from the API and the change itself is "locale independent".

@drewnoakes
Copy link
Owner

Thanks for these two PRs.

@LZaruba LZaruba mentioned this issue Apr 7, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drewnoakes @LZaruba