Change GifHeaderDirectory.TAG_TRANSPARENT_COLOR_INDEX to TAG_BACKGROUND_COLOR_INDEX #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ND_COLOR_INDEX GifHeaderDirectory class has TAG_TRANSPARENT_COLOR_INDEX tag, but its value is read from the Background Color Index field in the GIF header. The tag name should be TAG_BACKGROUND_COLOR_INDEX. This corresponds to the issue drewnoakes#141.
|
Thanks for this PR. Can you keep the old constant available too, but marked as obsolete? I don't like when updates cause users to experience compiler errors (but warnings about obsoletion are fine).
Can you also take a look at this? |
|
Marked the old constant TAG_TRANSPARENT_COLOR_INDEX as deprecated. I will work on the other blocks and extensions when I have spare time. |
drewnoakes
added a commit
that referenced
this pull request
Feb 3, 2016
Change GifHeaderDirectory.TAG_TRANSPARENT_COLOR_INDEX to TAG_BACKGROUND_COLOR_INDEX
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GifHeaderDirectory class has TAG_TRANSPARENT_COLOR_INDEX tag, but its value is read from the Background Color Index field in the GIF header. The tag name should be TAG_BACKGROUND_COLOR_INDEX. This closes #141.