Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings on elixir 1.11 #92

Merged
merged 2 commits into from
Oct 21, 2020

Conversation

pedroperrone
Copy link
Contributor

Currently, when we build the lib with elixir 1.11, we have the following warnings:

warning: Ecto.Query.Builder.Select.fields!/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query.Builder.Select]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:81

warning: Ecto.Query.Builder.Select.apply/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query.Builder.Select]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:94

warning: Ecto.Query.Builder.Select.apply/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query.Builder.Select]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:88

warning: Ecto.Query.Builder.Select.apply/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query.Builder.Select]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:81

warning: Ecto.Query.Builder.LimitOffset.apply/3 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query.Builder.LimitOffset]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:44

warning: Ecto.Query.subquery/1 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:93

warning: Ecto.Query.select/3 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:81

warning: Ecto.Query.select/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:94

warning: Ecto.Query.select/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:88

warning: Ecto.Query.offset/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:43

warning: Ecto.Query.limit/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:44

warning: Ecto.Query.exclude/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:87

warning: Ecto.Query.exclude/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:80

warning: Ecto.Query.exclude/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:63

warning: Ecto.Query.exclude/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:54

warning: Ecto.Query.exclude/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:53

warning: Ecto.Queryable.to_query/1 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Queryable]] to your "def project" in mix.exs

  lib/scrivener/paginater/atom.ex:7

@@ -4,7 +4,7 @@ services:
otp_release:
- 23.0
elixir:
- 1.10.3
- 1.11.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedroperrone I think would be nice to have also to run the CI against elixir 1.3 to ensure backwards compatibility with this changes, as it is the first version supported https://github.com/drewolson/scrivener_ecto/blob/master/mix.exs#L8

@drewolson drewolson merged commit 42a88e3 into drewolson:master Oct 21, 2020
@pedroperrone pedroperrone deleted the fix-warnings-on-elixir-1.11 branch October 21, 2020 14:34
@thiamsantos
Copy link

thiamsantos commented Oct 21, 2020

@drewolson We would love to have a new release with this fix, will help in our migration to elixir 1.11.

@drewolson
Copy link
Owner

@thiamsantos I should have a release out today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants