Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change import dynamic reader mechanism to simplify to custom dynamic readers #90

Merged
merged 1 commit into from Oct 2, 2019
Merged

Change import dynamic reader mechanism to simplify to custom dynamic readers #90

merged 1 commit into from Oct 2, 2019

Conversation

drgarcia1986
Copy link
Owner

No description provided.

@coveralls
Copy link

coveralls commented Oct 1, 2019 •
edited

Coverage Status

Coverage decreased (-0.04%) to 99.961% when pulling 5aa9ae8 on import_module into 4063858 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 98.329% when pulling 113429e on import_module into 4063858 on master.

jarussi
jarussi approved these changes Oct 2, 2019
View reviewed changes
Copy link

@jarussi jarussi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

simple_settings/dynamic_settings/__init__.py Outdated Show resolved Hide resolved
renanivo
renanivo reviewed Oct 2, 2019
View reviewed changes
Copy link

@renanivo renanivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it will generate a major release? Because it will be a breaking change for the current users of dynamic readers, right?

@drgarcia1986
Copy link
Owner Author

@renanivo hm makes sense, and I forgot to add changelog 🤦‍♂

@drgarcia1986 drgarcia1986 merged commit 13fbed9 into master Oct 2, 2019
@drgarcia1986 drgarcia1986 deleted the import_module branch October 2, 2019 16:45
@drgarcia1986 drgarcia1986 mentioned this pull request Oct 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renanivo renanivo renanivo approved these changes

@jarussi jarussi jarussi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@drgarcia1986 @coveralls @renanivo @jarussi