Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow parsing HexList selected from URL #5

Closed
drhus opened this issue Sep 12, 2018 · 3 comments
Closed

allow parsing HexList selected from URL #5

drhus opened this issue Sep 12, 2018 · 3 comments
Labels
enhancement New feature or request Priority: Medium

Comments

@drhus
Copy link
Owner

drhus commented Sep 12, 2018

currently, we parse: Mode, input from URL, will need to add the ability to parse "HexList"

@drhus drhus added enhancement New feature or request Priority: Medium labels Sep 12, 2018
@drhus drhus added this to the 0.7 - beta tester friendly milestone Sep 27, 2018
alexandrtovmach added a commit that referenced this issue Oct 11, 2018
@alexandrtovmach
Copy link
Collaborator

Solved

@drhus
Copy link
Owner Author

drhus commented Oct 12, 2018

the ?list=[name] is working however, it parse aswell wit both Export URL & View URL it shouldn't be like that

example https://momcode.io/lab/?list=Momcode-209 >> click on Export URL OR View URL it will print URL below with as ?list=Momcode-209&hexListV2= it should be ONLY ?hexListV2=

the ?list= variable should only be an input but not to be exported with URL or View URL (that would overwrite hexListV2

@drhus
Copy link
Owner Author

drhus commented Oct 12, 2018

Ooh I see what happen, the function of Export URL & View URL, will simply take the URL as it is and add to it instead,

We need to add to

document.querySelector('#generateTableURL').addEventListener('click', function () {

  • urlObj.searchParams.delete('list');

as well ass for #generateViewULR

document.querySelector('#generateViewURL').addEventListener('click', function () {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority: Medium
Projects
None yet
Development

No branches or pull requests

2 participants