Update to modern versions of libraries #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because: * The versions this was built against are all EOLed Solution: * Use Rails 5.x and 6.x * Use Ruby 2.6, 2.7, and 3 * Swap out TravisCI (RIP for public repos) and onto GitHub Actions
pbyrne
force-pushed
the
patrick/newer-rails
branch
from
9b0ecde
to
050fc93
Compare
pbyrne
commented
Aug 24, 2021
| if_option =~ /#{options[:on]}/ | ||
| end | ||
| end | ||
| callback.matches?(kind, name) |
There was a problem hiding this comment.
There's no reasonable way to assert against the if condition, as far as I can tell. And Callback#matches? handles the opening section of the any? block, so let's drastically simplify this code.
ehlertij
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
Solution: