-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub login support #227
Labels
Comments
loleg
added a commit
to loleg/dribdat
that referenced
this issue
Feb 23, 2021
This has been working reasonably well so far, however I sometimes get an error "Access denied to GitHub" which goes away on a second attempt to log in. Anyone else seeing this? |
@loleg is there an instance I could test this on? (besides setting it up locally, of course) |
@gonzalocasas yes, running at https://cividi.space |
LGTM! |
loleg
added a commit
to loleg/dribdat
that referenced
this issue
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's about time that we make it possible to login through GitHub. This is easy to add, though support for multiple SSO providers would need some refactoring. Not clear to me yet is also if we can define one global app to make it easier to set up.
This has been started with an initial PR in #228, however, it needs additional testing in particular to address the issue of token expiry described in flask-dance#35 thrown by
dribdat/public/auth.py
, line 235, in github_login.See official docs and #115
The text was updated successfully, but these errors were encountered: