add usage tracking about open/save clicks

add error handling to open external file
drichard · Jun 24, 2012 · eb233bb · eb233bb
1 parent c785ca2
commit eb233bb
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 4 deletions.
diff --git a/src/js/FilePicker.js b/src/js/FilePicker.js
@@ -40,9 +40,8 @@ mindmaps.FilePicker = function(eventBus, mindmapModel) {
           try {
             var doc = mindmaps.Document.fromJSON(data);
           } catch (e) {
-            console.error('Error while opening map from cloud', e);
             eventBus.publish(mindmaps.Event.NOTIFICATION_ERROR, 'File is not a valid mind map!');
-            return;
+            throw new Error('Error while opening map from cloud', e);
           }
 
           mindmapModel.setDocument(doc);

diff --git a/src/js/OpenDocument.js b/src/js/OpenDocument.js
@@ -103,6 +103,8 @@ mindmaps.OpenDocumentPresenter = function(eventBus, mindmapModel, view, filePick
    * Open file via cloud
    */
   view.openCloudButtonClicked = function(e) {
+    mindmaps.Util.trackEvent("Clicks", "cloud-open");
+
     filePicker.open({
       success: function() {
         view.hideOpenDialog();
@@ -113,7 +115,6 @@ mindmaps.OpenDocumentPresenter = function(eventBus, mindmapModel, view, filePick
     });
   };
 
-  // TODO experimental, catch errrs
   // http://www.w3.org/TR/FileAPI/#dfn-filereader
   /**
   * View callback: external file has been selected. Try to read and parse a
@@ -122,12 +123,19 @@ mindmaps.OpenDocumentPresenter = function(eventBus, mindmapModel, view, filePick
   * @ignore
   */
   view.openExernalFileClicked = function(e) {
+    mindmaps.Util.trackEvent("Clicks", "hdd-open");
+
     var files = e.target.files;
     var file = files[0];
 
     var reader = new FileReader();
     reader.onload = function() {
-      var doc = mindmaps.Document.fromJSON(reader.result);
+      try {
+        var doc = mindmaps.Document.fromJSON(reader.result);
+      } catch (e) {
+        eventBus.publish(mindmaps.Event.NOTIFICATION_ERROR, 'File is not a valid mind map!');
+        throw new Error('Error while opening map from hdd', e);
+      }
       mindmapModel.setDocument(doc);
       view.hideOpenDialog();
     };
@@ -143,6 +151,8 @@ mindmaps.OpenDocumentPresenter = function(eventBus, mindmapModel, view, filePick
   * @param {mindmaps.Document} doc
   */
   view.documentClicked = function(doc) {
+    mindmaps.Util.trackEvent("Clicks", "localstorage-open");
+
     mindmapModel.setDocument(doc);
     view.hideOpenDialog();
   };

diff --git a/src/js/SaveDocument.js b/src/js/SaveDocument.js
@@ -101,6 +101,8 @@ mindmaps.SaveDocumentPresenter = function(eventBus, mindmapModel, view, autosave
   * Save in cloud button was clicked.
   */
   view.cloudStorageButtonClicked = function() {
+    mindmaps.Util.trackEvent("Clicks", "cloud-save");
+
     filePicker.save({
       success: function() {
         view.hideSaveDialog();
@@ -118,6 +120,8 @@ mindmaps.SaveDocumentPresenter = function(eventBus, mindmapModel, view, autosave
   * @ignore
   */
   view.localStorageButtonClicked = function() {
+    mindmaps.Util.trackEvent("Clicks", "localstorage-save");
+
     var success = mindmapModel.saveToLocalStorage();
     if (success) {
       view.hideSaveDialog();
@@ -148,6 +152,8 @@ mindmaps.SaveDocumentPresenter = function(eventBus, mindmapModel, view, autosave
   * @returns {String}
   */
   view.fileNameRequested = function() {
+    mindmaps.Util.trackEvent("Clicks", "hdd-save");
+
     return mindmapModel.getMindMap().getRoot().getCaption() + ".json";
   };
 

diff --git a/src/js/Util.js b/src/js/Util.js
@@ -3,6 +3,21 @@
  */
 mindmaps.Util = mindmaps.Util || {};
 
+/**
+ * Tracks an event to google analytics.
+ */
+mindmaps.Util.trackEvent = function(category, action, label) {
+    if (!window._gaq) {
+      return;
+    }
+
+    if (label) {
+      _gaq.push([ '_trackEvent', category, action, label]);
+    } else {
+      _gaq.push([ '_trackEvent', category, action]);
+    }
+}
+
 /**
  * Creates a UUID in compliance with RFC4122.
  *