Feature/recover #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
==========================================
- Coverage 99.14% 97.82% -1.32%
==========================================
Files 16 16
Lines 1753 1793 +40
Branches 347 366 +19
==========================================
+ Hits 1738 1754 +16
- Misses 0 16 +16
- Partials 15 23 +8
Continue to review full report at Codecov.
|
Event PTR and RECERR can be enabled with resp. HPACK_CFG_SEND_PTR and HPACK_CFG_SEND_ERR
dguerizec
commented
Jul 23, 2020
lib/hpack_tbl.c
Outdated
| ctx->fld.val = hpack_unknown_value; | ||
| ctx->fld.nam_sz = strlen(ctx->fld.nam); | ||
| ctx->fld.val_sz = strlen(ctx->fld.val); | ||
| while(idx > ctx->hp->cnt) { |
There was a problem hiding this comment.
I don't like this loop, but don't know how to get rid of it.
Comments welcome!
Also avoid copy of sentinel values to be able to use them in event callback.
dguerizec
force-pushed
the
feature/recover
branch
from
15e3b63
to
05a7ae6
Compare
They were specifically centralized in tst.c to avoid repetition.
This offers a human readable string, convenient for event reporting. Signed-off-by: Dridi Boukelmoune <dridi.boukelmoune@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to force decoding if an index is unknown in the dynamic table.
This is enabled with the flag HPACK_CFG_DEGRADED passed to hpack_decoder().
Note: This needs more testing, and code coverage and documentation are not done yet.