[base][nav][search][timeline][remark] refactor size function to length (

#667) (#673) Co-authored-by: Dorien <dorien.drees@gmail.com>
driebit · Jul 21, 2020 · 861f14d · 861f14d
1 parent 361e261
commit 861f14d
Show file tree

Hide file tree

Showing 7 changed files with 594 additions and 594 deletions.
diff --git a/modules/mod_ginger_base/lib/js/content-group-nav.js b/modules/mod_ginger_base/lib/js/content-group-nav.js
@@ -17,7 +17,7 @@ $.widget( "ui.content_group_nav", {
 
         $(window).scroll($.proxy(me._scrolled, me));
 
-        if(me.banner.size() > 0) {
+        if(me.banner.length > 0) {
             me.body.addClass('has-content-group');
         }
 
@@ -29,7 +29,7 @@ $.widget( "ui.content_group_nav", {
     },
 
     _scrolled: function(event) {
-        
+
         var me = this,
             scrollTop = $(window).scrollTop(),
             minPoint = me.subnav.outerHeight() + 20,

diff --git a/modules/mod_ginger_base/lib/js/map-location.js b/modules/mod_ginger_base/lib/js/map-location.js
@@ -183,7 +183,7 @@
             var me = this,
                 mainContentEl = $('.' + me.element.data('main-content-class'));
 
-                if (mainContentEl.size() == 0) return false;
+                if (mainContentEl.length == 0) return false;
 
                 var masthead = $(me.element),
                 mastheadHeight = masthead[0].clientHeight,

diff --git a/modules/mod_ginger_base/lib/js/search/expand-items.js b/modules/mod_ginger_base/lib/js/search/expand-items.js
@@ -21,7 +21,7 @@ $.widget("ui.expanditems", {
 
         button.hide();
 
-        if (inputs.size() > showMax) {
+        if (inputs.length > showMax) {
 
             button.show();
 

diff --git a/modules/mod_ginger_nav/lib/js/src/mod_ginger_nav.js b/modules/mod_ginger_nav/lib/js/src/mod_ginger_nav.js
@@ -19,7 +19,7 @@ $.widget( "ui.mod_ginger_nav", {
         me.mainMenu         = $(widgetElement.find('.mod_ginger_nav__main-nav__container__menu')[0]),
         me.menuButton       = $(widgetElement.find('.mod_ginger_nav__main-nav__toggle-menu')[0]),
         me.themeBanner      = $(widgetElement.find('.mod_ginger_nav__theme-banner')[0]),
-       
+
         //listeners
         me.searchButton.on('click', $.proxy(me._toggleSearch, me));
         me.document.on('click', $.proxy(me._documentClick, me));
@@ -28,17 +28,17 @@ $.widget( "ui.mod_ginger_nav", {
         me.themeBanner.on('click', $.proxy(me._scrollToTop, me));
 
         //init
-        if(me.themeBanner.size() > 0) {
+        if(me.themeBanner.length > 0) {
             me.body.addClass('has-theme');
         }
-        
+
 
     },
 
     _documentClick: function(event) {
 
         var me = this;
-        
+
         if (!$(event.target).closest('.mod_ginger_nav__main-nav').length) {
            if (me.searchForm.hasClass('is-visible')) {
                me._toggleSearch();
@@ -49,7 +49,7 @@ $.widget( "ui.mod_ginger_nav", {
     _toggleSearch: function() {
 
         var me = this;
-        
+
         me.searchButton.toggleClass('is-active');
 
          if(me.searchButton.hasClass('is-active')) {

diff --git a/modules/mod_ginger_remark/lib/js/remark_widget.js b/modules/mod_ginger_remark/lib/js/remark_widget.js
@@ -120,7 +120,7 @@
                 valid = false;
             }
 
-            if (anonymousName.size() > 0) {
+            if (anonymousName.length > 0) {
                 if (!re.test(anonymousName.val())) {
                     anonymousName.parent().addClass('has-error is-error');
                     valid = false;

diff --git a/modules/mod_ginger_search/lib/js/ginger-search.js b/modules/mod_ginger_search/lib/js/ginger-search.js
@@ -65,7 +65,7 @@
                     closest = $(e.target).closest(container);
 
                  if (!container.is(e.target) // if the target of the click isn't the container...
-                     && closest.size() == 0)
+                     && closest.length == 0)
                  {
                     $('.ginger-search').removeClass('is-visible');