Add keyword resources as suggest and add titles of keywords edges #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddeboer
force-pushed
the
autocomplete_keywords
branch
from
1105444
to
ff8f333
Compare
ddeboer
reviewed
Jul 11, 2017
support/elasticsearch_mapping.erl
Outdated
| [], | ||
| m_edge:objects(Id, subject, Context) | ||
| ), | ||
| [{keywords, ObjectTitles}] |
There was a problem hiding this comment.
Better to store this in the incoming|outgoing_edges nested items.
| ElasticQuery = #{ | ||
| <<"suggest">> => #{ | ||
| <<"suggest">> => #{ | ||
| <<"prefix">> => Prefix, | ||
| <<"completion">> => #{ | ||
| <<"field">> => Field | ||
| <<"field">> => Field, |
There was a problem hiding this comment.
Would Field suggest_* be possible?
| <<"suggest">> => #{ | ||
| <<"suggest">> => #{ | ||
| <<"text">> => Word, | ||
| <<"term">> => #{ |
There was a problem hiding this comment.
Change into terms with multiple fields: title*?
ddeboer
changed the title
…r rsc's WIP did you mean suggest Fixed did-you-mean query Size configurable and didyoumean sort on freq Removed debug
ddeboer
force-pushed
the
autocomplete_keywords
branch
from
748410e
to
13ba4c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds keyword rsc's to suggest:completion field, weighted on popularity.
It also adds titles of keywords to the keywords field so the general match can handle the suggested keyword title.
It's WIP for solving #3
and #12