Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update postal code exceptions for Portugal #174

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

toyi
Copy link
Contributor

@toyi toyi commented May 13, 2024

A full postal code for the Azores is 9[5-9]xx-xxx but the regex never matches this format since it only looks for numbers.

This PR fixes this issue, for both the Azores and Madeira. It makes 9500 trigger the exception, as well as 9500-339.

I also noticed the current regex allowed 950000000.... (with unlimited digits). It seems to be useless since Portuguese postal codes are only 4 digits before the hyphen, but I kept this behavior in order to avoid an undesirable breaking change. So 95012341234-339 will match too.

@driesvints driesvints merged commit d678f79 into driesvints:3.x May 14, 2024
18 checks passed
@driesvints
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants