Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier config and run it on JS #12

Merged

Conversation

paulgb
Copy link
Member

@paulgb paulgb commented Jul 26, 2023

Also adds a github workflow to ensure that prettier has run.

We may also want to run eslint in the workflow, but I'll wait for #3 to land for that as I think it fixes an eslint warning.

@paulgb paulgb requested a review from rolyatmax July 26, 2023 21:41
@linear
Copy link

linear bot commented Jul 26, 2023

DIS-1157 Set up formatter for JS (examples / tests) in y-serve

taylor do you have a preferred style config?

@vercel
Copy link

vercel bot commented Jul 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
y-serve ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2023 10:05pm
y-serve-demos ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2023 10:05pm

Copy link
Member

@rolyatmax rolyatmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@paulgb paulgb merged commit 28ff1e9 into main Jul 26, 2023
5 checks passed
@paulgb paulgb deleted the paul/dis-1157-set-up-formatter-for-js-examples-tests-in-y-serve branch July 26, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants