Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

Revisit Source Maps #431

Closed
3 tasks done
danbucholtz opened this issue Nov 18, 2016 · 6 comments
Closed
3 tasks done

Revisit Source Maps #431

danbucholtz opened this issue Nov 18, 2016 · 6 comments
Assignees

Comments

@danbucholtz
Copy link
Contributor

danbucholtz commented Nov 18, 2016

  • Not all of ionic-angular has a source map

  • Investigate cheaper source map options with original source

  • Improve docs and show an example

@rajpat
Copy link

rajpat commented Dec 8, 2016

Hi @danbucholtz

Is there a solution yet to get source-maps working on Windows ?
This is seriously affecting our enterprise app development as our Ionic 2 development environment is on Windows 7 Enterprise.
Is there a solution yet to get source-maps working on Windows ?

@danbucholtz
Copy link
Contributor Author

@rajpat,

Yes, it should work in 0.0.47.

Thanks,
Dan

@olivermuc
Copy link

Have you guys got source maps working, finally?
I just downloaded the latest "ionic2-app-base", with the npm modules installed:

├── @angular/common@2.2.1
├── @angular/compiler@2.2.1
├── @angular/compiler-cli@2.2.1
├── @angular/core@2.2.1
├── @angular/forms@2.2.1
├── @angular/http@2.2.1
├── @angular/platform-browser@2.2.1
├── @angular/platform-browser-dynamic@2.2.1
├── @angular/platform-server@2.2.1
├── @ionic/app-scripts@0.0.47
├── @ionic/storage@1.1.6
├── ionic-angular@2.0.0-rc.4
├── ionic-native@2.2.11
├── ionicons@3.0.0
├── rxjs@5.0.0-beta.12
├── typescript@2.0.9
└── zone.js@0.6.26

Still no source maps in Safari (running the app in ios Simulator).
What am I missing?

Thanks!

@pjc2007
Copy link

pjc2007 commented Dec 19, 2016 via email

@olivermuc
Copy link

olivermuc commented Dec 19, 2016

Apologies, should have been clearer about the issue.

The source map is generated (main.js.map) in the build/ folder, but apparently not loaded / considered by Safari. I also can't judge whether the created map is legit.

I do see statements in the main.js file:
//# sourceMappingURL=index.js.map

I may know enough about how source maps are loaded and correlated but it strikes me that one JS file can have multiple individual source map directives that essentially point to non existent files.

EDIT:
tried adding this: "ionic_source_map_type": "eval"
and voila the *.ts counterparts started to appear in Safari.

EDIT2:
could have been the reloading within Safari as well, which interestingly enough kills the emulator/app 2 out of 3 times...jeez.

@snortblt
Copy link

I've tried everything I can think of and everything I've found here to get source maps working in safari with ionic 3. Should this just work out of the box at this point? Debugging on iOS is very frustrating for me a present.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants