fix(stats): Updated cli to only track on valid commands.

ionic-team · Aug 2, 2016 · 9308577 · 9308577
1 parent cc4ee64
commit 9308577
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/lib/cli.js b/lib/cli.js
@@ -119,9 +119,6 @@ Cli.run = function run(processArgv) {
       });
     }
 
-    // Gather stats on the current command execution
-    IonicStats.t();
-
     var taskName = argv._[0];
     var task = Cli.getTaskSettingsByName(taskName);
     log.debug('Task:', task);
@@ -134,6 +131,9 @@ Cli.run = function run(processArgv) {
 
     var booleanOptions = Cli.getListOfBooleanOptions(task.options);
 
+    // Gather stats on the current command execution
+    IonicStats.t();
+
     // Remove all possible task boolean options from the args
     argv = optimist(rawCliArguments)
       .boolean(booleanOptions)

diff --git a/spec/cli.spec.js b/spec/cli.spec.js
@@ -162,6 +162,15 @@ describe('Cli', function() {
         });
       });
 
+      it('should not track stats for cli for a bogus command', function(done) {
+
+        IonicCli.run(['node', 'bin/ionic', 'helper'])
+        .then(function() {
+          expect(IonicStats.t).not.toHaveBeenCalled();
+          done();
+        });
+      });
+
       it('should change cwd to project root for project tasks', function(done) {
         var processArguments = ['node', 'bin/ionic', 'fake'];
         var rawCliArguments = processArguments.slice(2);