Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interface difference between CloudPath and its children #234

Closed
jruere opened this issue Jun 2, 2022 · 1 comment · Fixed by #250
Closed

Interface difference between CloudPath and its children #234

jruere opened this issue Jun 2, 2022 · 1 comment · Fixed by #250
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jruere
Copy link

jruere commented Jun 2, 2022

In class CloudPath, stat is a property.

On all of the class children, stat is a method.

This looks like a mistake.
@pjbull
Copy link
Member

pjbull commented Jun 2, 2022

Thanks @jruere, the property is an error on CloudPath. We'd accept a PR to remove it. stat should be a method in order to follow pathlib: https://docs.python.org/3/library/pathlib.html#pathlib.Path.stat

@pjbull pjbull added bug Something isn't working good first issue Good for newcomers labels Jun 2, 2022
@pjbull pjbull mentioned this issue Aug 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make stat a method on CloudPath class drivendataorg/cloudpathlib
2 participants
@jruere @pjbull