Make stat a method on CloudPath class #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
========================================
- Coverage 95.0% 94.8% -0.2%
========================================
Files 21 21
Lines 1324 1323 -1
========================================
- Hits 1258 1255 -3
- Misses 66 68 +2
|
jayqi
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
stata method instead of a property to follow pathlib API.Note: this is technically a potentially breaking change for anyone who implemented their own plugin
CloudPathsubclass, but didn't overridestat. All of our classes overridestatas a method properly.Bonus fix for #203 since upstream breaking change was fixed we can unpin our
pytestversionFixes #234
Fixes #203