Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make prefix not being recognised as dirs anymore #244

Merged
merged 4 commits into from Aug 11, 2022

Conversation

frndmg
Copy link
Contributor

@frndmg frndmg commented Aug 4, 2022

Fixes #208

Copy link
Member

@pjbull pjbull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @frndmg! We have to get this onto a branch rather than a fork to do the live tests, but lets make the updates here for the tests first.

tests/test_s3_specific.py Outdated Show resolved Hide resolved
tests/test_s3_specific.py Outdated Show resolved Hide resolved
@frndmg
Copy link
Contributor Author

frndmg commented Aug 8, 2022

@pjbull, thanks for your review!

Now testing for mocked backend and using already uploaded files.

Let me know if there is anything else that needs to be adjusted 👍

Feel free to push this to a local branch 👍

@frndmg frndmg requested a review from pjbull August 10, 2022 20:51
@pjbull
Copy link
Member

pjbull commented Aug 10, 2022

Thanks @frndmg! Once CI passes here, I'll pull over to a local branch to run the tests against live servers

@pjbull
Copy link
Member

pjbull commented Aug 10, 2022

Actually, would you mind adding a note in the HISTORY.md as well? I believe you need to start a new "unreleased" section. Here's an old one for reference:

## v0.7.2 (UNRELEASED)
- Fixed pickling of `CloudPath` objects not working. ([Issue #223](https://github.com/drivendataorg/cloudpathlib/issues/223), [PR #224](https://github.com/drivendataorg/cloudpathlib/pull/224))

@frndmg
Copy link
Contributor Author

frndmg commented Aug 11, 2022

@pjbull feel free to update the message in the HISTORY.md if you want

@pjbull pjbull changed the base branch from master to 244-cloud-tests August 11, 2022 15:40
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2022

Codecov Report

Merging #244 (c76c96a) into 244-cloud-tests (2e52c05) will decrease coverage by 0.5%.
The diff coverage is 100.0%.

@@                Coverage Diff                @@
##           244-cloud-tests    #244     +/-   ##
=================================================
- Coverage             95.0%   94.4%   -0.6%     
=================================================
  Files                   21      21             
  Lines                 1323    1324      +1     
=================================================
- Hits                  1257    1251      -6     
- Misses                  66      73      +7     
Impacted Files Coverage Δ
cloudpathlib/s3/s3client.py 92.9% <100.0%> (-2.6%) ⬇️
cloudpathlib/gs/gsclient.py 92.8% <0.0%> (-1.8%) ⬇️
cloudpathlib/cloudpath.py 93.5% <0.0%> (-0.5%) ⬇️

@pjbull pjbull merged commit e781f1f into drivendataorg:244-cloud-tests Aug 11, 2022
pjbull added a commit that referenced this pull request Aug 11, 2022
* make prefix not being recognised as dirs anymore

* update tests

* remove unnecessary  fixture

* update history

Co-authored-by: Fernando <frndmartinezglez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3Path.exists() returns True on partial matches
3 participants