Short-circuit 'easy' rglob/glob patterns

[Gilthans]

Resolves #274

[Gilthans]

@pjbull friendly ping :)

[pjbull]

Thanks @Gilthans, while I think this fix looks directionally reasonable, but I'd like to do a bit more investigation on why performance is bad in #274.

I assumed that it was because there was a network call somewhere in the glob path, but we actually only call the list dir once here:

cloudpathlib/cloudpathlib/cloudpath.py

Lines 349 to 358 in b7f6010

	def _glob(self, selector):
	root = _CloudPathSelectable(
	PurePosixPath(self._no_prefix_no_drive),
	{
	PurePosixPath(c._no_prefix_no_drive): is_dir
	for c, is_dir in self.client._list_dir(self, recursive=True)
	},
	is_dir=True,
	exists=True,
	)

If you get a chance, could you do some profiling and report in #274? I'm hoping there may be a better more general fix than the short circuit if this isn't networking related (or maybe it is and I just missed where the call is in my scan of the code).

[Gilthans]

I assumed that it was because there was a network call somewhere in the glob path, but we actually only call the list dir once here:

I actually came to the same conclusion before opening the issue. I got that far into the code and couldn't figure out why it was slow either.
I'd love to do this profiling (one of my hobbies actually :) ), but in the meantime, maybe we could push forward with this? It seems to me like a net-positive regardless

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.4%. Comparing base (b7f6010) to head (9e56b09).

Additional details and impacted files

@@               Coverage Diff                @@
##           276-live-tests    #276     +/-   ##
================================================
- Coverage            94.8%   94.4%   -0.4%     
================================================
  Files                  20      20             
  Lines                1314    1323      +9     
================================================
+ Hits                 1246    1250      +4     
- Misses                 68      73      +5     

Files with missing lines	Coverage Δ
cloudpathlib/cloudpath.py	93.7% <100.0%> (+0.1%)	⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.