Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests #297

Merged
merged 1 commit into from
Dec 4, 2022
Merged

Fix failing tests #297

merged 1 commit into from
Dec 4, 2022

Conversation

pjbull
Copy link
Member

@pjbull pjbull commented Dec 4, 2022

We're not in control of what mimetypes guesses, and on some systems/versions of Python the javascript mimetype can be different.

Closes #296

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2022

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2022

Codecov Report

Merging #297 (ee26b99) into master (96759b0) will decrease coverage by 0.1%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #297     +/-   ##
========================================
- Coverage    95.0%   94.8%   -0.2%     
========================================
  Files          20      20             
  Lines        1327    1327             
========================================
- Hits         1261    1259      -2     
- Misses         66      68      +2     
Impacted Files Coverage Δ
cloudpathlib/cloudpath.py 93.7% <0.0%> (-0.5%) ⬇️

@pjbull pjbull merged commit 31f93ac into master Dec 4, 2022
@pjbull pjbull deleted the 296-failing-tests branch December 4, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed build on master branch (tests #625)
2 participants