Make CloudPath.is_valid_cloudpath a TypeGuard #337
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually a
TypeGuard
I had implemented in my own codebase, but I recently realized it is doing exactly the same thing asis_valid_cloudpath
. This allows us to infer thatCloudPath
s are the same type of object as the classis_valid_cloudpath
is called on!I opened an issue with mypy regarding this strange behavior which only seems to arise on
TypeGuard
methods: python/mypy#15401