Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip mtime checks during upload when force_overwrite_to_cloud is set #384

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

pjbull
Copy link
Member

@pjbull pjbull commented Dec 11, 2023

Live tests for (#380)


  • Skip mtime checks during upload when force_overwrite_to_cloud is set

  • Lint fix

  • Updated HISTORY.md

DESCRIPTION_HERE

Closes #ISSUE


Contributor checklist:

  • I have read and understood CONTRIBUTING.md
  • Confirmed an issue exists for the PR, and the text Closes #issue appears in the PR summary (e.g., Closes #123).
  • Confirmed PR is rebased onto the latest base
  • Confirmed failure before change and success after change
  • Any generic new functionality is replicated across cloud providers if necessary
  • Tested manually against live server backend for at least one provider
  • Added tests for any new functionality
  • Linting passes locally
  • Tests pass locally
  • Updated HISTORY.md with the issue that is addressed and the PR you are submitting. If the top section is not `## UNRELEASED``, then you need to add a new section to the top of the document for your change.

…380)

* Skip mtime checks during upload when force_overwrite_to_cloud is set

* Lint fix

* Updated HISTORY.md
Copy link
Contributor

@github-actions github-actions bot temporarily deployed to pull request December 11, 2023 18:20 Inactive
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #384 (1be5354) into master (c5eaf7e) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #384   +/-   ##
======================================
  Coverage    93.7%   93.7%           
======================================
  Files          22      22           
  Lines        1563    1566    +3     
======================================
+ Hits         1465    1468    +3     
  Misses         98      98           
Files Coverage Δ
cloudpathlib/cloudpath.py 91.9% <100.0%> (+<0.1%) ⬆️

@pjbull pjbull merged commit 41aa53d into master Dec 11, 2023
28 checks passed
@pjbull
Copy link
Member Author

pjbull commented Dec 11, 2023

Thanks @Gilthans

@pjbull pjbull deleted the 380-live-tests branch December 11, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants