Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to demo deck on homepage #140

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Add link to demo deck on homepage #140

merged 2 commits into from
Jan 23, 2024

Conversation

ejm714
Copy link
Collaborator

@ejm714 ejm714 commented Jan 23, 2024

Adds a sentence with a link to the demo deck to the top section of the home page. Alternatively, we could make this its own tab to feature it more prominently. Not strongly opinionated on where it goes, just wanted to make the demo deck publicly available.

Copy link

render bot commented Jan 23, 2024

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (140686c) 75.0% compared to head (245d121) 75.0%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #140   +/-   ##
=====================================
  Coverage   75.0%   75.0%           
=====================================
  Files         12      12           
  Lines        863     863           
=====================================
  Hits         648     648           
  Misses       215     215           

Copy link
Collaborator

@klwetstone klwetstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ejm714 Good idea! LGTM. I like how you included it as a link rather than directly featured on a page. To me, it makes it clearer that the first-stop "entry point" for using the package is the homepage of the docs, and the deck is useful supplementary material.

Also the deck is just ✨ ✨ -- there are some new slides I hadn't seen!

@ejm714 ejm714 merged commit f06f7ed into main Jan 23, 2024
10 checks passed
@ejm714 ejm714 deleted the demo-deck branch January 23, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants