Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better documentation, management of GPU/CPU auto selection in makefile #15

Merged
merged 1 commit into from Oct 1, 2020
Merged

Better documentation, management of GPU/CPU auto selection in makefile #15

merged 1 commit into from Oct 1, 2020

Conversation

r-b-g-b
Copy link
Collaborator

@r-b-g-b r-b-g-b commented Sep 30, 2020 •
edited

Closes https://github.com/drivendataorg/deid2-collaboration/issues/34
Closes https://github.com/drivendataorg/deid2-collaboration/issues/35

  • Better documentation for using the CPU_OR_GPU flag in the makefile. Specifically state that machines w nvidia-smi and CUDA!=11 will need to manually set.
  • Easier selection of GPU_ARGS. Now manually setting CPU_OR_GPU=cpu will also set GPU_ARGS=.

@r-b-g-b r-b-g-b requested a review from pjbull September 30, 2020 23:13
pjbull
pjbull approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@pjbull pjbull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Makefile Show resolved Hide resolved
@r-b-g-b r-b-g-b merged commit 8caeb9b into master Oct 1, 2020
@r-b-g-b r-b-g-b deleted the note-about-gpu branch October 1, 2020 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjbull pjbull pjbull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r-b-g-b @pjbull