[#48] fixing security vulnerability in npm package and a bug in calli…

…ng the api in sucession [cf]
drkchn · Jun 30, 2023 · b0f50d8 · b0f50d8
1 parent 82357a5
commit b0f50d8
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 18 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/components/addressSearchBar/AddressSearchBar.tsx b/src/components/addressSearchBar/AddressSearchBar.tsx
@@ -109,9 +109,6 @@ export const AddressSearchBar = ({ isHomePage }: AddressSearchBarProps) => {
         console.log(res);
         setRepresentativeDataResponse(res.data);
         setRepresentativeCallSuccessful(true);
-
-        // Call the query for elections API after the representative call is successful
-        queryAvailableElectionsAPI();
       })
       .catch((err) => {
         // Catch any errors in the api chain
@@ -120,7 +117,8 @@ export const AddressSearchBar = ({ isHomePage }: AddressSearchBarProps) => {
         setSnackBarIsOpen(true);
       })
       .finally(() => {
-        setButtonIsDisabled(false);
+        // Call the query for elections API after the representative call is successful
+        queryAvailableElectionsAPI();
       });
   };
 
@@ -135,6 +133,16 @@ export const AddressSearchBar = ({ isHomePage }: AddressSearchBarProps) => {
         // Setting the state on successful response
         setAvailableElections(res.data);
         setElectionCallSuccessful(true);
+      })
+      .catch((err) => {
+        console.log(err);
+        if (!snackBarIsOpen) {
+          setGoogleApiErrorMessage(err.response.data.error.message);
+          setSnackBarIsOpen(true);
+        }
+      })
+      .finally(() => {
+        setButtonIsDisabled(false);
       });
   };