(Thor) Pubsub data missing #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvin620707
approved these changes
Jul 20, 2018
jonascheng
reviewed
Jul 20, 2018
| future = self.client.publish(topic, payload, **kwargs) | ||
| logger.debug('Executed client.publish. pid: %s.', os.getpid()) |
There was a problem hiding this comment.
這log是懷疑pid不一樣嗎？按照future的用法應該不至於吧？
There was a problem hiding this comment.
因為發生retry後，懷疑gunicorn有timeout問題，需要利用pid對應gunicron 的log
| # async call | ||
| if callback is not None: | ||
| future.add_done_callback(lambda future: self.__on_published(future, callback)) | ||
| return (None, future) | ||
| return None, future |
There was a problem hiding this comment.
why need to make this change?
| # sync call | ||
| else: | ||
| logger.debug('Execute future.result. pid: %s.', os.getpid()) |
There was a problem hiding this comment.
與其加只檢查的pid的log, 不如在future.result加上一個timeout, 如果超過時間會有相對應的exception
|
@jonascheng 這個等你到辦公室後討論。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/236282096786725/751030429860586