Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable code coverage #149

Merged
merged 1 commit into from Sep 12, 2017
Merged

Disable code coverage #149

merged 1 commit into from Sep 12, 2017

Conversation

dbmrq
Copy link
Contributor

@dbmrq dbmrq commented Sep 11, 2017

Code coverage has to be disabled for Carthage to work with Xcode 9.

Check Carthage/Carthage#2056 and Carthage/Carthage#2057.

@drmohundro
Copy link
Owner

Hey, just double checking as this is the first I've heard of this - are you aware of any means of getting code coverage gathered in addition to also supporting Carthage? I'm certainly more interested in supporting Carthage, but it does sting a little to lose out on code coverage metrics.

@dbmrq
Copy link
Contributor Author

dbmrq commented Sep 12, 2017

Well, I'm not an expert, but except for using multiple schemes I don't think there's any other option for now: Carthage/Carthage#2057 (comment)

I'm hoping Carthage will start using the archive action, like I suggested here, but I don't know if it's gonna happen and even if it does it might take some time.

@drmohundro drmohundro merged commit 88095d2 into drmohundro:master Sep 12, 2017
@drmohundro
Copy link
Owner

Merged - I guess I'll keep an eye on it in case. Give me a second and I'll push another tagged version out.

@dbmrq
Copy link
Contributor Author

dbmrq commented Sep 12, 2017

Thanks! Hopefully there'll be a better way soon.

@drmohundro
Copy link
Owner

👍 4.2.1 is now published. Thanks!

@dbmrq
Copy link
Contributor Author

dbmrq commented Sep 21, 2017

Just so you know, Carthage/Carthage#2158 should fix this issue on Carthage's side. That PR isn't included in a release yet, but you can probably go back to using code coverage soon. :)

@drmohundro
Copy link
Owner

@dbmrq awesome, thanks for keeping an eye on that and letting me know - I appreciate it!

drmohundro added a commit that referenced this pull request Oct 30, 2017
Reverses #149 now that Carthage 0.26.0 is released which enables archive
functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants