-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update XML API for Swift 5.1 on Linux #216
Conversation
With Swift 5.1 corelibs foundation introduced a new module called FoundationXML and moved all XMLParser related API there. This adds compatibility for that while still supporting Swift 5.0
Ok it looks like Swift 4.x doesn't support allow using the |
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
=======================================
Coverage 78.56% 78.56%
=======================================
Files 13 13
Lines 2398 2398
=======================================
Hits 1884 1884
Misses 514 514
Continue to review full report at Codecov.
|
I've pushed that to see if CI is happy with it at least |
@keith thanks for the PR! I was actually about to respond but it looks like you noticed that already. I'm also fine with bumping the |
Up to you! But if this iteration works I guess you can decide to do that independently of adding 5.1 support |
Yep, still doesn't like that flag either...
I'm happy to make the change tomorrow or let you if you if you can get to it sooner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks! |
I'll get |
With Swift 5.1 corelibs foundation introduced a new module called
FoundationXML and moved all XMLParser related API there. This adds
compatibility for that while still supporting Swift 5.0