Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Entity filter is hiding after selecting entity from list #154

Closed
1 task done
kedaroh-bh opened this issue May 6, 2024 · 0 comments
Closed
1 task done

bug: Entity filter is hiding after selecting entity from list #154

kedaroh-bh opened this issue May 6, 2024 · 0 comments

Comments

@kedaroh-bh
Copy link
Contributor

kedaroh-bh commented May 6, 2024

Issue

Entity filter is hiding after selecting entity from list

Pre-requisite

Entities should be configured in local_dev.yaml and there should be a questions linked to some of the entities.

Steps to Reproduce

  1. Go to root page
  2. Open filters panel
  3. Select entity from entity dropdown
  4. Entity dropdown disappears.

Root Cause

There is showEntityFilter prop passed to FilterPanel component and its value is set based on there is entity query params is present, which looks unnecessary, Entity filter should only depends on if there are entities available and on top of it if user purposefully want it to be hidden irrespectively available entities by manually passing showEntityFilter as false.

  • Ready to work on fix

Screenshots

Without selecting entity filter hence no query param:
image

With entity filter selected hence there is a entity query param:
image

Duplicate entity refs in entity filter dropdown after selection:
qeta_fix_issue_#154_showing_selected_entity_twice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants