-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ux: Light Theme Accessibility #37
Comments
Thanks for the report! Good findings and should be quite easy to fix. The plugin uses the default MUI components and styles with only few exceptions. It's a bit weird that the default theme renders these so badly. Have to try this out with the light theme a bit more and maybe convert these buttons to follow the primary button style, like you suggested. I will check this tomorrow! |
This is now released in 1.3.1, please try it out! |
Awesome, thanks @drodil! Updating now - looks great! |
markdown editor also to follow the styling of theme fixes #37
Description
Backstage instances that use a Custom Theme (or the builtin Light Theme) have a few accessibility issues when it comes to some of the component variant usage/colors.
Primarily, the Buttons to Create new Questions blend in with the background and look like they are
disabled
and not actionable at an immediate glanceExamples
Landing Page with no Questions Asked
Go Ahead and Ask One!
button looks like just plain textAsk Question
in the top right doesn't look actionable and is hard to see immediatelyAsking a Question
POST
button in the bottom left to submit the Form looks like it isdisabled
and not actionable when the question is properly filled outAnswering a Question
Similar issues, most buttons blend into background or look
disabled
Expected Behavior
These buttons should respect the configured
primary
theme colors defined in a Backstage instanceFor example, our theme uses a Lighter Green for Primary actions/buttons
Ideally, this plugin continued using the theme for actions/buttons.
The text was updated successfully, but these errors were encountered: