Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ux: Light Theme Accessibility #37

Closed
alecjacobs5401 opened this issue Feb 6, 2023 · 4 comments
Closed

ux: Light Theme Accessibility #37

alecjacobs5401 opened this issue Feb 6, 2023 · 4 comments

Comments

@alecjacobs5401
Copy link

Description

Backstage instances that use a Custom Theme (or the builtin Light Theme) have a few accessibility issues when it comes to some of the component variant usage/colors.

Primarily, the Buttons to Create new Questions blend in with the background and look like they are disabled and not actionable at an immediate glance

Examples

Landing Page with no Questions Asked

image

  • The Go Ahead and Ask One! button looks like just plain text
  • The Ask Question in the top right doesn't look actionable and is hard to see immediately

Asking a Question

image

  • The POST button in the bottom left to submit the Form looks like it is disabled and not actionable when the question is properly filled out

Answering a Question

image

Similar issues, most buttons blend into background or look disabled

Expected Behavior

These buttons should respect the configured primary theme colors defined in a Backstage instance

For example, our theme uses a Lighter Green for Primary actions/buttons
image

Ideally, this plugin continued using the theme for actions/buttons.

@drodil
Copy link
Owner

drodil commented Feb 6, 2023

Thanks for the report! Good findings and should be quite easy to fix. The plugin uses the default MUI components and styles with only few exceptions. It's a bit weird that the default theme renders these so badly. Have to try this out with the light theme a bit more and maybe convert these buttons to follow the primary button style, like you suggested.

I will check this tomorrow!

@drodil
Copy link
Owner

drodil commented Feb 7, 2023

Hm. With the default light theme, the buttons look fine:
image

Could it be just your theme that messes the font color in the button? I might still try the primary buttons for this.

@drodil drodil closed this as completed in b06436c Feb 7, 2023
@drodil
Copy link
Owner

drodil commented Feb 7, 2023

This is now released in 1.3.1, please try it out!

@alecjacobs5401
Copy link
Author

Awesome, thanks @drodil! Updating now - looks great!

drodil added a commit that referenced this issue Mar 7, 2023
markdown editor also to follow the styling of theme

fixes #37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants