add support for dst/src addr/port pathspecs #74
Conversation
%f - dest address %h - dest port %t - source address %v - source port format specifiers to pathspec
|
Your solution causes getnameinfo() to be called twice for every endpoint (once for the host and once for the port). Can you change that into a single call of getnameinfo() by writing a derivative of sys_sockaddr_str() that returns host and port into separate buffers but only calls getnameinfo() once, instead of having separate helpers for host and port? |
|
I can try but no promises :) I'm really not a c programmer. Aside from that, does the patch look ok? |
|
Thanks! I try to thoroughly test patches before merging them so no worries :) |
|
Are you still working on this? |
|
FYI, I'm now working on separating host and port into distinct members of the state ctx structure and rewriting |
Store host and port in separate strings internally and get rid of the
[host]:port representation where separate host and port would be
cleaner. This includes the following user-visible changes:
- Generated filenames that contain host and port, such as by -S and
-F %d and %s, now use a host,port format instead of [host]:port.
- Connect log now uses separate fields for host and port.
Issue: #69 #74
Reported by: Adam Jacob Muller
Issue: #74 Submitted by: Adam Jacob Muller
|
Merged to |
add support for:
format specifiers to pathspec
The goal of this is to allow pathspecs like:
This improves upon the existing %s/%d for two big reasons
#1 using %s/%d results in unusable directory structures, because of the inclusion of the randomized source port address
#2 the inclusion of the brackets inside the %s/%d specifiers is sub-optimal in filesystems
I would point out, I am not a C programmer by trade and barely know C, this patch does work for me but is perhaps sub-optimal. Comments/improvements are definitely welcome.