[feat] console - add pagination #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "last page" button is disabled for now, as the registry does not sends back the total number of devices when limiting. So we cannot calculate the total number of page. Allow to pass query options to the wasm request builder
jbtrystram
changed the title
|
/test |
|
Aye, aye, captain! … Triggered System Test worklow! |
ctron
approved these changes
May 18, 2022
There was a problem hiding this comment.
LGTM! Let's check what the CI has to say about it.
I am not happy with the added "query" parameter. However, I am also not happy with the other parameters of this function 😁 … so let's keep this pattern for now (as it is consistent), but maybe refactor this into some more builder-style pattern in the future.
Git: Job: https://github.com/drogue-iot/drogue-cloud-testing/actions/runs/2345953449 Report: https://drogue-iot.github.io/drogue-cloud-testing/test-report/2022/05/18/test-run-2345953449.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "last page" button is acting as a "next" button, as the registry does not
sends back the total number of devices when limiting, so we cannot calculate the total number of pages. This seems to be the recommended behaviour in patternfly examples.
Allow to pass query options to the wasm request builder