Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align generation field with k8s api #279

Merged
merged 1 commit into from May 12, 2022
Merged

fix: align generation field with k8s api #279

merged 1 commit into from May 12, 2022

Conversation

ctron
Copy link
Member

@ctron ctron commented May 11, 2022

This change only incremenets the generation field when
a change of spec section has occurred. Internally there
is a revision field, which increments with every change.
However, that is not exposed, as the resourceVersion field
should be used for detecting any change. While the
generation field is intended to track changes of the
specification.

This fixes the "obverved generation" never being equal
to the "generation", as the status section update again
increments the generation field.

@ctron ctron added this to the 0.10.0 milestone May 11, 2022
@ctron ctron added the bug Something isn't working label May 11, 2022
@ctron
Copy link
Member Author

ctron commented May 11, 2022

/test

@drogue-bot
Copy link

Aye, aye, captain! … Triggered System Test worklow!

This change only incremenets the generation field when
a change of spec section has occurred. Internally there
is a revision field, which increments with every change.
However, that is not exposed, as the resourceVersion field
should be used for detecting any change. While the
generation field is intended to track changes of the
specification.

This fixes the "obverved generation" never being equal
to the "generation", as the status section update again
increments the generation field.
@drogue-bot
Copy link

Total Passed Failed Ignored Filtered Duration
147 146 1 0 0 38m 56s

Git: https://github.com/drogue-iot/drogue-cloud @ refs/heads/feature/revgen_1

Commit: 1ee6bda37163b52ef83ab99d4ee4b7ca6458350c
Author: Jens Reimann <jreimann@redhat.com>
Date: Wed, 11 May 2022 13:12:38 -0200

    fix: align generation field with k8s api
    
    This change only incremenets the generation field when
    a change of spec section has occurred. Internally there
    is a revision field, which increments with every change.
    However, that is not exposed, as the resourceVersion field
    should be used for detecting any change. While the
    generation field is intended to track changes of the
    specification.
    
    This fixes the "obverved generation" never being equal
    to the "generation", as the status section update again
    increments the generation field.

Job: https://github.com/drogue-iot/drogue-cloud-testing/actions/runs/2308008604

Report: https://drogue-iot.github.io/drogue-cloud-testing/test-report/2022/05/11/test-run-2308008604.html

@ctron ctron merged commit 0be1f63 into main May 12, 2022
@ctron ctron deleted the feature/revgen_1 branch May 12, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants