Allow read_to_end with ChunkedEncoding #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
commented
Nov 11, 2023
| if let HttpConnection::Tls(ref mut tls) = self.stream { | ||
| return tls.fill_buf().await.map_err(|e| e.kind()); | ||
| // The matches/if let dance is to fix lifetime of the borrowed inner connection. | ||
| if self.stream.try_fill_buf().await.is_some() { |
There was a problem hiding this comment.
@rmja This got handy here, too :)
|
Do we want to return BufferTooSmall errors in the "outer" |
|
Now this PR comes with a fix to an absolutely embarassingly dumb mistake :) |
Add failing test case Introduce TryBufRead, clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to do a bunch of refactoring, because I had to create an abstraction for
maybe-BufReadtypes (and I had to implement that for the tokio adapter stuff). This is because ChunkedEncoding's new reader function works via BufRead.A downside of this PR is that
read_to_endis only available forTryBufReadtypes, which we only define forHttpConnectionin the library, and the tokio adapter in the tests.The PR can most likely be simplified, I was just aiming to get it working and it took long enough.