Skip to content

Commit

Permalink
Fixed bug with ImageView. Fixes SC sproutcore#380.
Browse files Browse the repository at this point in the history
  • Loading branch information
jribar authored and Colin Campbell committed May 13, 2011
1 parent 236f518 commit 0e0cee1
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion frameworks/foundation/render_delegates/canvas_image.js
Expand Up @@ -78,10 +78,11 @@ SC.BaseTheme.canvasImageRenderDelegate = SC.RenderDelegate.create({

// We only care about specific values, check specifically for what matters
var innerFrameDidChange = ![innerFrame.x, innerFrame.y, innerFrame.width, innerFrame.height].isEqual(renderState._lastInnerFrameValues),
elemSizeDidChange = ![elem.width, elem.height].isEqual(renderState._lastElemSizeValues),
backgroundDidChange = dataSource.didChangeFor('canvasImageRenderDelegate', 'backgroundColor'),
imageDidChange = dataSource.didChangeFor('canvasImageRenderDelegate', 'image') || (image && image.complete) !== renderState._lastImageComplete;

if (innerFrameDidChange || backgroundDidChange || imageDidChange) {
if (elemSizeDidChange || innerFrameDidChange || backgroundDidChange || imageDidChange) {

if (elem && elem.getContext) {
elem.height = frameHeight;
Expand All @@ -103,6 +104,7 @@ SC.BaseTheme.canvasImageRenderDelegate = SC.RenderDelegate.create({

// Update caches
renderState._lastInnerFrameValues = [innerFrame.x, innerFrame.y, innerFrame.width, innerFrame.height];
renderState._lastElemSizeValues = [elem.width, elem.height];
renderState._lastImageComplete = image && image.complete;
}
}
Expand Down

0 comments on commit 0e0cee1

Please sign in to comment.