[ISSUE #301] 添加JMX监控采集类型 #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KamToHung
commented
Jan 13, 2024
| @Data | ||
| @Builder | ||
| @NoArgsConstructor | ||
| @AllArgsConstructor |
There was a problem hiding this comment.
这里需要构造函数，但是不知道加这两个注解（加了@builder原因）好还是新增一个类复制这些属性好
There was a problem hiding this comment.
没看到哪儿需要构造函数呢
MXBean 里面成员对象需要构造函数
There was a problem hiding this comment.
了解了，要不去掉@builder吧，用的地方好像就一处
There was a problem hiding this comment.
了解了，要不去掉@builder吧，用的地方好像就一处
OK，我改下
|
PTAL |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#301
